From: Alexei Gradinari <alex2grad@gmail.com>
Date: Wed, 14 Aug 2019 19:52:01 +0000 (-0400)
Subject: app_voicemail/IMAP: check mailstream not NULL in leave_voicemail
X-Git-Tag: 17.0.0-rc1~4
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7591e0f3a42d250df56653ca05297be879dfeddc;p=thirdparty%2Fasterisk.git

app_voicemail/IMAP: check mailstream not NULL in leave_voicemail

The function leave_voicemail checks if expungeonhangup is set,
but does not check if IMAP stream is closed,
so it could call imap function with NULL stream.
This leads to segfault.

ASTERISK-28505 #close

Change-Id: Ib66c57c1f1ba97774e447b36349198e2626a8d7c
---

diff --git a/apps/app_voicemail.c b/apps/app_voicemail.c
index 405dddf025..a4797282f0 100644
--- a/apps/app_voicemail.c
+++ b/apps/app_voicemail.c
@@ -7179,7 +7179,7 @@ leave_vm_out:
 #ifdef IMAP_STORAGE
 	/* expunge message - use UID Expunge if supported on IMAP server*/
 	ast_debug(3, "*** Checking if we can expunge, expungeonhangup set to %d\n", expungeonhangup);
-	if (expungeonhangup == 1) {
+	if (expungeonhangup == 1 && vms->mailstream != NULL) {
 		ast_mutex_lock(&vms->lock);
 #ifdef HAVE_IMAP_TK2006
 		if (LEVELUIDPLUS (vms->mailstream)) {