From: Frederic Bourgeois <fredbmail@free.fr>
Date: Fri, 29 Nov 2013 04:24:51 +0000 (-0700)
Subject: Bug 3782: Digest authentication not obeying nonce_max_count
X-Git-Tag: SQUID_3_4_0_3~5
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=759c107710cdef539d6da749fa1a166baa198f5d;p=thirdparty%2Fsquid.git

Bug 3782: Digest authentication not obeying nonce_max_count
---

diff --git a/src/auth/digest/UserRequest.cc b/src/auth/digest/UserRequest.cc
index e9fc63012b..977169ba95 100644
--- a/src/auth/digest/UserRequest.cc
+++ b/src/auth/digest/UserRequest.cc
@@ -149,14 +149,14 @@ Auth::Digest::UserRequest::authenticate(HttpRequest * request, ConnStateData * c
             digest_request->setDenyMessage("Incorrect password");
             return;
         }
+    }
 
-        /* check for stale nonce */
-        if (!authDigestNonceIsValid(digest_request->nonce, digest_request->nc)) {
-            debugs(29, 3, HERE << "user '" << auth_user->username() << "' validated OK but nonce stale");
-            auth_user->credentials(Auth::Failed);
-            digest_request->setDenyMessage("Stale nonce");
-            return;
-        }
+    /* check for stale nonce */
+    if (!authDigestNonceIsValid(digest_request->nonce, digest_request->nc)) {
+        debugs(29, 3, "user '" << auth_user->username() << "' validated OK but nonce stale");
+        auth_user->credentials(Auth::Failed);
+        digest_request->setDenyMessage("Stale nonce");
+        return;
     }
 
     auth_user->credentials(Auth::Ok);