From: David Vossel <dvossel@digium.com>
Date: Mon, 7 Dec 2009 23:24:59 +0000 (+0000)
Subject: hex escape control and non 7-bit clean characters in uri_encode
X-Git-Tag: 1.4.28-rc1~7^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=75b2fba708be04456406104a6173b0625f52a0f9;p=thirdparty%2Fasterisk.git

hex escape control and non 7-bit clean characters in uri_encode

In ast_uri_encode, non 7-bit clean characters were being hex escaped
correctly, but control characters were not.

(issue #16299)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@233609 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/main/utils.c b/main/utils.c
index 97991efe18..f835e11fcd 100644
--- a/main/utils.c
+++ b/main/utils.c
@@ -394,7 +394,7 @@ char *ast_uri_encode(const char *string, char *outbuf, int buflen, int doreserve
 
 	/* If there's no characters to convert, just go through and don't do anything */
 	while (*ptr) {
-		if (((unsigned char) *ptr) > 127 || (doreserved && strchr(reserved, *ptr)) ) {
+		if ((*ptr < 32) || (doreserved && strchr(reserved, *ptr))) {
 			/* Oops, we need to start working here */
 			if (!buf) {
 				buf = outbuf;