From: Tom Eastep <teastep@shorewall.net>
Date: Thu, 15 Nov 2007 13:06:58 +0000 (+0000)
Subject: PATCH - Fix for --random option in DNAT and REDIRECT
X-Git-Tag: v1.4.0~42
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=75b4b2081522ab2f680ca0edf2242bc6f28a0ef7;p=thirdparty%2Fiptables.git

PATCH - Fix for --random option in DNAT and REDIRECT

The --random option produces "Unknown arg `--random'" errors with both the
DNAT and REDIRECT targets. Corrected by the attached patch.

Tom Eastep <teastep@shorewall.net>
---

diff --git a/extensions/libipt_DNAT.c b/extensions/libipt_DNAT.c
index eaed57b3..7322a204 100644
--- a/extensions/libipt_DNAT.c
+++ b/extensions/libipt_DNAT.c
@@ -178,6 +178,7 @@ static int DNAT_parse(int c, char **argv, int invert, unsigned int *flags,
 			*flags |= IPT_DNAT_OPT_RANDOM;
 		} else
 			*flags |= IPT_DNAT_OPT_RANDOM;
+		return 1;
 	default:
 		return 0;
 	}
diff --git a/extensions/libipt_REDIRECT.c b/extensions/libipt_REDIRECT.c
index 077b6d88..f749dd1e 100644
--- a/extensions/libipt_REDIRECT.c
+++ b/extensions/libipt_REDIRECT.c
@@ -23,7 +23,7 @@ IPTABLES_VERSION);
 
 static const struct option REDIRECT_opts[] = {
 	{ "to-ports", 1, NULL, '1' },
-	{ "random", 1, NULL, '2' },
+	{ "random", 0, NULL, '2' },
 	{ }
 };