From: Daniel P. Berrangé <berrange@redhat.com>
Date: Fri, 25 Jan 2019 11:09:10 +0000 (+0000)
Subject: remote: remove variable whose value is a constant
X-Git-Tag: v5.1.0-rc1~309
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=75d4defe8f4f42da9e99387541ad60a0e417d0a5;p=thirdparty%2Flibvirt.git

remote: remove variable whose value is a constant

The 'rv' variable is never changed after being declared, so can be
removed.

Reviewed-by: John Ferlan <jferlan@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---

diff --git a/src/remote/remote_daemon_dispatch.c b/src/remote/remote_daemon_dispatch.c
index fcd602304f..df28259042 100644
--- a/src/remote/remote_daemon_dispatch.c
+++ b/src/remote/remote_daemon_dispatch.c
@@ -3659,7 +3659,6 @@ remoteDispatchAuthSaslStart(virNetServerPtr server,
     const char *serverout;
     size_t serveroutlen;
     int err;
-    int rv = -1;
     struct daemonClientPrivate *priv =
         virNetServerClientGetPrivateData(client);
     const char *identity;
@@ -3739,8 +3738,7 @@ remoteDispatchAuthSaslStart(virNetServerPtr server,
     virResetLastError();
     virReportError(VIR_ERR_AUTH_FAILED, "%s",
                    _("authentication failed"));
-    if (rv < 0)
-        virNetMessageSaveError(rerr);
+    virNetMessageSaveError(rerr);
     virMutexUnlock(&priv->lock);
     return -1;
 }
@@ -3757,7 +3755,6 @@ remoteDispatchAuthSaslStep(virNetServerPtr server,
     const char *serverout;
     size_t serveroutlen;
     int err;
-    int rv = -1;
     struct daemonClientPrivate *priv =
         virNetServerClientGetPrivateData(client);
     const char *identity;
@@ -3837,8 +3834,7 @@ remoteDispatchAuthSaslStep(virNetServerPtr server,
     virResetLastError();
     virReportError(VIR_ERR_AUTH_FAILED, "%s",
                    _("authentication failed"));
-    if (rv < 0)
-        virNetMessageSaveError(rerr);
+    virNetMessageSaveError(rerr);
     virMutexUnlock(&priv->lock);
     return -1;
 }