From: Klaus Ethgen <Klaus@Ethgen.de>
Date: Tue, 27 Apr 2010 07:20:47 +0000 (+0200)
Subject: The base used for conversion of USB values should be 16 not 10.
X-Git-Tag: v0.8.1~38
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=75d88455f54088f88bc7a503da0a4cd413ef7b95;p=thirdparty%2Flibvirt.git

The base used for conversion of USB values should be 16 not 10.

Signed-off-by: Guido Günther <agx@sigxcpu.org>
---

diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_device_udev.c
index b12a49e961..3a5a7e2e44 100644
--- a/src/node_device/node_device_udev.c
+++ b/src/node_device/node_device_udev.c
@@ -548,8 +548,6 @@ out:
 }
 
 
-/* XXX Is 10 the correct base for the Number/Class/SubClass/Protocol
- * conversions?  */
 static int udevProcessUSBInterface(struct udev_device *device,
                                    virNodeDeviceDefPtr def)
 {
@@ -559,28 +557,28 @@ static int udevProcessUSBInterface(struct udev_device *device,
     if (udevGetUintSysfsAttr(device,
                              "bInterfaceNumber",
                              &data->usb_if.number,
-                             10) == PROPERTY_ERROR) {
+                             16) == PROPERTY_ERROR) {
         goto out;
     }
 
     if (udevGetUintSysfsAttr(device,
                              "bInterfaceClass",
                              &data->usb_if._class,
-                             10) == PROPERTY_ERROR) {
+                             16) == PROPERTY_ERROR) {
         goto out;
     }
 
     if (udevGetUintSysfsAttr(device,
                              "bInterfaceSubClass",
                              &data->usb_if.subclass,
-                             10) == PROPERTY_ERROR) {
+                             16) == PROPERTY_ERROR) {
         goto out;
     }
 
     if (udevGetUintSysfsAttr(device,
                              "bInterfaceProtocol",
                              &data->usb_if.protocol,
-                             10) == PROPERTY_ERROR) {
+                             16) == PROPERTY_ERROR) {
         goto out;
     }