From: Volker Lendecke <vl@samba.org>
Date: Tue, 3 Nov 2020 11:33:12 +0000 (+0100)
Subject: lib: Slightly optimize smb_fname_str_dbg()
X-Git-Tag: samba-4.14.0rc1~676
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=76043ccb7f0f73e114776182469da8a96589a826;p=thirdparty%2Fsamba.git

lib: Slightly optimize smb_fname_str_dbg()

Don't leak "fname"

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/lib/filename_util.c b/source3/lib/filename_util.c
index fb79dab09bd..f535ea1f088 100644
--- a/source3/lib/filename_util.c
+++ b/source3/lib/filename_util.c
@@ -165,10 +165,8 @@ const char *smb_fname_str_dbg(const struct smb_filename *smb_fname)
 		return "";
 	}
 
-	fname = talloc_asprintf(talloc_tos(),
-				"%s {%s}",
-				fname,
-				tstr);
+	fname = talloc_asprintf_append_buffer(
+		fname, " {%s}", tstr);
 	if (fname == NULL) {
 		return "";
 	}