From: Harald Hoyer <harald@redhat.com>
Date: Fri, 12 Feb 2021 12:26:12 +0000 (+0100)
Subject: fix: shellcheck for modules.d/95cifs/cifsroot.sh
X-Git-Tag: 052~40
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=760a4370f03e1045046c9b17013311cb7b540b83;p=thirdparty%2Fdracut.git

fix: shellcheck for modules.d/95cifs/cifsroot.sh
---

diff --git a/modules.d/95cifs/cifsroot.sh b/modules.d/95cifs/cifsroot.sh
index 11d362e8e..351f8b8df 100755
--- a/modules.d/95cifs/cifsroot.sh
+++ b/modules.d/95cifs/cifsroot.sh
@@ -7,18 +7,18 @@ type getarg >/dev/null 2>&1 || . /lib/dracut-lib.sh
 
 # root is in the form root=cifs://user:pass@[server]/[folder] either from
 # cmdline or dhcp root-path
-netif="$1"
+#netif="$1"
 root="$2"
 NEWROOT="$3"
 
-cifs_to_var $root
-echo server: $server
-echo path: $path
-echo options: $options
+cifs_to_var "$root"
 
+# shellcheck disable=SC2154
 mount.cifs "//$server/$path" "$NEWROOT" -o "$options" && { [ -e /dev/root ] || ln -s null /dev/root ; }
 
 # inject new exit_if_exists
-echo 'settle_exit_if_exists="--exit-if-exists=/dev/root"; rm -f -- "$job"' > $hookdir/initqueue/cifs.sh
+# shellcheck disable=SC2016
+# shellcheck disable=SC2154
+echo 'settle_exit_if_exists="--exit-if-exists=/dev/root"; rm -f -- "$job"' > "$hookdir"/initqueue/cifs.sh
 # force udevsettle to break
-> $hookdir/initqueue/work
+: > "$hookdir"/initqueue/work