From: Julian Seward <jseward@acm.org>
Date: Fri, 16 Nov 2007 19:39:49 +0000 (+0000)
Subject: Make one redirect mandatory for ppc64-linux.
X-Git-Tag: svn/VALGRIND_3_3_0~124
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=760e1d046ecf9c62cdda0318a2811ea992e252f5;p=thirdparty%2Fvalgrind.git

Make one redirect mandatory for ppc64-linux.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@7167
---

diff --git a/coregrind/m_redir.c b/coregrind/m_redir.c
index 9cf3f990d5..c2252c4655 100644
--- a/coregrind/m_redir.c
+++ b/coregrind/m_redir.c
@@ -870,8 +870,10 @@ void VG_(redir_initialise) ( void )
    /* If we're using memcheck, use these intercepts right from
       the start, otherwise ld.so makes a lot of noise. */
    if (0==VG_(strcmp)("Memcheck", VG_(details).name)) {
-      const HChar* croakage = "Possible fix: install glibc's debuginfo "
-                              "package on this machine.";
+
+      static HChar* croakage = "Possible fix: install glibc's debuginfo "
+                               "package on this machine.";
+
       /* this is mandatory - can't sanely continue without it */
       add_hardwired_spec(
          "ld.so.1", "strlen",
@@ -897,16 +899,21 @@ void VG_(redir_initialise) ( void )
       the start, otherwise ld.so makes a lot of noise. */
    if (0==VG_(strcmp)("Memcheck", VG_(details).name)) {
 
+      static HChar* croakage = "Possible fix: install glibc's debuginfo "
+                               "package on this machine.";
+
+      /* this is mandatory - can't sanely continue without it */
       add_hardwired_spec(
          "ld64.so.1", "strlen",
          (Addr)VG_(fnptr_to_fnentry)( &VG_(ppc64_linux_REDIR_FOR_strlen) ),
-         NULL
+         croakage
       );
 
       add_hardwired_spec(
          "ld64.so.1", "index",
          (Addr)VG_(fnptr_to_fnentry)( &VG_(ppc64_linux_REDIR_FOR_strchr) ),
-         NULL
+         NULL /* not mandatory - so why bother at all? */
+         /* glibc-2.5 (FC6, ppc64) seems fine without it */
       );
 
    }