From: Michael Tremer <michael.tremer@ipfire.org>
Date: Wed, 10 Dec 2025 16:09:53 +0000 (+0000)
Subject: exporter: Create the RRset only once
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=76261b11c1f236600aaefea738ac422c28c47b70;p=dbl.git

exporter: Create the RRset only once

Since all records have the same rrset, we simply create it only once
instead of doing this every time we iterate over our loop.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/src/dnsbl/exporters.py b/src/dnsbl/exporters.py
index 60a4ece..c2ffd33 100644
--- a/src/dnsbl/exporters.py
+++ b/src/dnsbl/exporters.py
@@ -186,13 +186,18 @@ class ZoneExporter(TextExporter):
 
 		# XXX Add NS
 
+		# Compute the rrset
+		rrset = dns.rdataset.from_text(
+			dns.rdataclass.IN, self.type, ttl, self.content,
+		)
+
 		# Write all domains
 		for domain in self.list.domains:
 			zone.replace_rdataset(
-				dns.name.from_text("%s.%s" % (domain, self.list.zone), origin=origin),
-				dns.rdataset.from_text(
-					dns.rdataclass.IN, self.type, ttl, self.content,
+				dns.name.from_text(
+					"%s.%s" % (domain, self.list.zone), origin=origin,
 				),
+				rrset,
 			)
 
 		# Add ZONEMD