From: Philippe Antoine <pantoine@oisf.net>
Date: Mon, 26 Feb 2024 16:28:25 +0000 (+0100)
Subject: output/filestore: remove duplicate snprintf
X-Git-Tag: suricata-8.0.0-beta1~1701
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7641c07af95f4373c50812890737358fda885a4c;p=thirdparty%2Fsuricata.git

output/filestore: remove duplicate snprintf

Ticket: 6796
---

diff --git a/src/output-filestore.c b/src/output-filestore.c
index 607fe292ff..d67014d49e 100644
--- a/src/output-filestore.c
+++ b/src/output-filestore.c
@@ -194,10 +194,7 @@ static int OutputFilestoreLogger(ThreadVars *tv, void *thread_data, const Packet
 
     SCLogDebug("ff %p, data %p, data_len %u", ff, data, data_len);
 
-    char base_filename[PATH_MAX] = "";
-    snprintf(base_filename, sizeof(base_filename), "%s/file.%u",
-            ctx->tmpdir, ff->file_store_id);
-    snprintf(filename, sizeof(filename), "%s", base_filename);
+    snprintf(filename, sizeof(filename), "%s/file.%u", ctx->tmpdir, ff->file_store_id);
 
     if (flags & OUTPUT_FILEDATA_FLAG_OPEN) {
         file_fd = open(filename, O_CREAT | O_TRUNC | O_NOFOLLOW | O_WRONLY,