From: Tom Hughes Date: Wed, 19 Aug 2015 08:27:06 +0000 (+0000) Subject: Install the SIGILL handler everywhere so we get consistent X-Git-Tag: svn/VALGRIND_3_11_0~90 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7678f91cd1c9602217afb2f821bb16585e692cbe;p=thirdparty%2Fvalgrind.git Install the SIGILL handler everywhere so we get consistent stacks and don't have to worry about __GLIBC_PREREQ not being defined on all platforms. git-svn-id: svn://svn.valgrind.org/valgrind/trunk@15567 --- diff --git a/drd/tests/tc12_rwl_trivial.stderr.exp b/drd/tests/tc12_rwl_trivial.stderr.exp index 1a67b3d603..ae7aa0ac58 100644 --- a/drd/tests/tc12_rwl_trivial.stderr.exp +++ b/drd/tests/tc12_rwl_trivial.stderr.exp @@ -1,7 +1,7 @@ Reader-writer lock not locked by calling thread: rwlock 0x......... at 0x........: pthread_rwlock_unlock (drd_pthread_intercepts.c:?) - by 0x........: safe_pthread_rwlock_unlock (safe-pthread.h:43) + by 0x........: safe_pthread_rwlock_unlock (safe-pthread.h:42) by 0x........: main (tc12_rwl_trivial.c:29) rwlock 0x........ was first observed at: at 0x........: pthread_rwlock_init (drd_pthread_intercepts.c:?) diff --git a/helgrind/tests/safe-pthread.h b/helgrind/tests/safe-pthread.h index 1210f3a851..0e4b244c91 100644 --- a/helgrind/tests/safe-pthread.h +++ b/helgrind/tests/safe-pthread.h @@ -26,7 +26,6 @@ static void sigill_handler( int signum, siginfo_t *siginfo, void *sigcontext ) { * glibc normally does - error reporting is optional. */ static int safe_pthread_rwlock_unlock( pthread_rwlock_t *rwlock ) { -#if __GLIBC_PREREQ(2,20) && ( defined(__i386__) || defined(__x86_64__) ) struct sigaction sa; struct sigaction oldsa; int r; @@ -48,9 +47,6 @@ static int safe_pthread_rwlock_unlock( pthread_rwlock_t *rwlock ) { sigaction( SIGILL, &oldsa, NULL ); return r; -#else - return pthread_rwlock_unlock( rwlock ); -#endif } #define pthread_rwlock_unlock safe_pthread_rwlock_unlock