From: Jim Meyering <meyering@redhat.com>
Date: Wed, 6 Jan 2010 11:59:21 +0000 (+0100)
Subject: xend_internal: don't let invalid input provoke NULL dereference
X-Git-Tag: v0.7.6~231
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7679f064bfd1e0de27a28c809294c41fef36610a;p=thirdparty%2Flibvirt.git

xend_internal: don't let invalid input provoke NULL dereference

* src/xen/xend_internal.c (xenDaemonOpen_unix): Do not dereference
a NULL "conn".  Move first deref to follow the "conn == NULL" test.
---

diff --git a/src/xen/xend_internal.c b/src/xen/xend_internal.c
index 827aac4b76..be033f5c11 100644
--- a/src/xen/xend_internal.c
+++ b/src/xen/xend_internal.c
@@ -748,11 +748,12 @@ int
 xenDaemonOpen_unix(virConnectPtr conn, const char *path)
 {
     struct sockaddr_un *addr;
-    xenUnifiedPrivatePtr priv = (xenUnifiedPrivatePtr) conn->privateData;
+    xenUnifiedPrivatePtr priv;
 
     if ((conn == NULL) || (path == NULL))
         return (-1);
 
+    priv = (xenUnifiedPrivatePtr) conn->privateData;
     memset(&priv->addr, 0, sizeof(priv->addr));
     priv->addrfamily = AF_UNIX;
     /*