From: Erik Skultety Date: Thu, 28 Jun 2018 08:55:47 +0000 (+0200) Subject: qemu: validate: Enforce compile time switch type checking for videos X-Git-Tag: v4.6.0-rc1~285 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=767f9e1449b1a36111532847f0c62dc758263c42;p=thirdparty%2Flibvirt.git qemu: validate: Enforce compile time switch type checking for videos There wasn't an explicit type case to the video type enum in qemuDomainDeviceDefValidateVideo, _TYPE_GOP was also missing from the switch. Signed-off-by: Erik Skultety Reviewed-by: John Ferlan --- diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 1fc1734bcc..0f10e242fd 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -1453,7 +1453,7 @@ struct _virDomainVideoDriverDef { }; struct _virDomainVideoDef { - int type; + int type; /* enum virDomainVideoType */ unsigned int ram; /* kibibytes (multiples of 1024) */ unsigned int vram; /* kibibytes (multiples of 1024) */ unsigned int vram64; /* kibibytes (multiples of 1024) */ diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index b10bbc40a4..964fe97963 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -4470,10 +4470,11 @@ qemuDomainDeviceDefValidateHostdev(const virDomainHostdevDef *hostdev, static int qemuDomainDeviceDefValidateVideo(const virDomainVideoDef *video) { - switch (video->type) { + switch ((virDomainVideoType) video->type) { case VIR_DOMAIN_VIDEO_TYPE_XEN: case VIR_DOMAIN_VIDEO_TYPE_VBOX: case VIR_DOMAIN_VIDEO_TYPE_PARALLELS: + case VIR_DOMAIN_VIDEO_TYPE_GOP: case VIR_DOMAIN_VIDEO_TYPE_DEFAULT: virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("video type '%s' is not supported with QEMU"),