From: jocuri%softhome.net <>
Date: Sun, 5 Dec 2004 22:18:59 +0000 (+0000)
Subject: Patch for bug 271048: Remove confusion when sorting classifications by modifying... 
X-Git-Tag: bugzilla-2.19.2~96
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=768b72850d3f3292506b1ddd1bc7ced794b32883;p=thirdparty%2Fbugzilla.git

Patch for bug 271048: Remove confusion when sorting classifications by modifying GetSelectableClassifications in order to always return a sorted list; patch by Albert Ting <altlst@sonic.net>, r=justdave, a=justdave.
---

diff --git a/globals.pl b/globals.pl
index 829417e440..d1e751bb0d 100644
--- a/globals.pl
+++ b/globals.pl
@@ -664,7 +664,7 @@ sub GetSelectableProductHash {
 sub GetSelectableClassifications {
     my @selectable_classes = ();
 
-    foreach my $c (keys %::classdesc) {
+    foreach my $c (sort keys %::classdesc) {
         if ( scalar(GetSelectableProducts(0,$c)) > 0) {
            push(@selectable_classes,$c);
         }
diff --git a/query.cgi b/query.cgi
index c22a11471f..931913a9f0 100755
--- a/query.cgi
+++ b/query.cgi
@@ -280,7 +280,7 @@ $vars->{'product'} = \@products;
 if (Param('useclassification')) {
     my @classifications = ();
 
-    foreach my $c (sort(GetSelectableClassifications())) {
+    foreach my $c (GetSelectableClassifications()) {
         # Create hash to hold attributes for each classification.
         my %classification = (
             'name'       => $c,