From: Russell Bryant <russell@russellbryant.com>
Date: Thu, 12 Feb 2009 20:45:47 +0000 (+0000)
Subject: Avoid using ast_strdupa() in a loop.
X-Git-Tag: 1.6.2.0-beta1~244
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=768c73160e1074cc30d8d0b96062370133da3c7e;p=thirdparty%2Fasterisk.git

Avoid using ast_strdupa() in a loop.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@175295 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/channels/chan_sip.c b/channels/chan_sip.c
index bfbdba3853..b5dbdeca89 100644
--- a/channels/chan_sip.c
+++ b/channels/chan_sip.c
@@ -7670,7 +7670,8 @@ static int process_sdp(struct sip_pvt *p, struct sip_request *req, int t38action
 	/* XXX This needs to be done per media stream, since it's media stream specific */
 	iterator = req->sdp_start;
 	while ((a = get_sdp_iterate(&iterator, req, "a"))[0] != '\0') {
-		char* mimeSubtype = ast_strdupa(a); /* ensures we have enough space */
+		char mimeSubtype[128];
+		ast_copy_string(mimeSubtype, a, sizeof(mimeSubtype));
 		if (option_debug > 1) {
 			int breakout = FALSE;