From: jocuri%softhome.net <>
Date: Sat, 12 Jun 2004 00:03:50 +0000 (+0000)
Subject: Patch for bug 245976: fix software error caused by taint issue when trying to add... 
X-Git-Tag: bugzilla-2.18rc1~44
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=769f4071b43017decf24293fb15fdea5245bf712;p=thirdparty%2Fbugzilla.git

Patch for bug 245976: fix software error caused by taint issue when trying to add a milestone; patch by Byron Jones (glob) <bugzilla@glob.com.au>; r=vladd, a=justdave.
---

diff --git a/editmilestones.cgi b/editmilestones.cgi
index 43cded1eac..5100577eed 100755
--- a/editmilestones.cgi
+++ b/editmilestones.cgi
@@ -294,7 +294,7 @@ if ($action eq 'new') {
         PutTrailer($localtrailer);
         exit;
     }
-    if ($sortkey!~/^[0-9]+$/) {
+    if (!detaint_natural($sortkey)) {
         print "The sortkey for a milestone must be a number. Please press\n";
         print "<b>Back</b> and try again.\n";
         PutTrailer($localtrailer);