From: Daniel P. Berrangé <berrange@redhat.com>
Date: Fri, 27 Mar 2020 14:38:49 +0000 (+0000)
Subject: scripts: avoid error in DCO check on empty branches
X-Git-Tag: v6.2.0-rc1~8
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=769ff77c9c5afaec97350a4931e5ca123b6af6d2;p=thirdparty%2Flibvirt.git

scripts: avoid error in DCO check on empty branches

If the DCO check is run on an empty branch (ie one which has no commits
different from master), it throws an error due to trying to interpret
the empty string as a git commit SHA.

Reviewed-by: Andrea Bolognani <abologna@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---

diff --git a/scripts/require-dco.py b/scripts/require-dco.py
index 9fe13823a9..ae94393319 100755
--- a/scripts/require-dco.py
+++ b/scripts/require-dco.py
@@ -46,7 +46,10 @@ print("\nChecking for 'Signed-off-by: NAME <EMAIL>' on all commits since %s...\n
 log = subprocess.check_output(["git", "log", "--format=%H %s", ancestor + "..."],
                               universal_newlines=True)
 
-commits = [[c[0:40], c[41:]] for c in log.strip().split("\n")]
+if log == "":
+    commits = []
+else:
+    commits = [[c[0:40], c[41:]] for c in log.strip().split("\n")]
 
 for sha, subject in commits: