From: Pauli <pauli@openssl.org>
Date: Fri, 29 Jul 2022 02:08:04 +0000 (+1000)
Subject: Coverity 1507484: dereference before null check
X-Git-Tag: openssl-3.2.0-alpha1~2311
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=76ad9ae6fa459af0bd804c01d3d681ec02cddb4b;p=thirdparty%2Fopenssl.git

Coverity 1507484: dereference before null check

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/18907)
---

diff --git a/ssl/tls_srp.c b/ssl/tls_srp.c
index 2f1d2198fd1..962e4d70740 100644
--- a/ssl/tls_srp.c
+++ b/ssl/tls_srp.c
@@ -90,9 +90,9 @@ int SSL_SRP_CTX_free(SSL *s)
  */
 int ssl_srp_ctx_init_intern(SSL_CONNECTION *s)
 {
-    SSL_CTX *ctx = SSL_CONNECTION_GET_CTX(s);
+    SSL_CTX *ctx;
 
-    if (s == NULL || ctx == NULL)
+    if (s == NULL || (ctx = SSL_CONNECTION_GET_CTX(s)) == NULL)
         return 0;
 
     memset(&s->srp_ctx, 0, sizeof(s->srp_ctx));