From: Daan De Meyer <daan.j.demeyer@gmail.com>
Date: Tue, 2 Jul 2024 21:43:13 +0000 (+0200)
Subject: Add rw to extra kernel command line by default
X-Git-Tag: v24~65^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=76cc01ed4eef2a462f8de629b68d4d581dba9a62;p=thirdparty%2Fmkosi.git

Add rw to extra kernel command line by default

This generally makes more sense as the default for us instead of
ro.
---

diff --git a/mkosi/config.py b/mkosi/config.py
index 429c75544..48e12f2c3 100644
--- a/mkosi/config.py
+++ b/mkosi/config.py
@@ -3760,6 +3760,7 @@ def load_kernel_command_line_extra(args: argparse.Namespace) -> list[str]:
     term = finalize_term()
 
     cmdline = [
+        "rw",
         # Make sure we set up networking in the VM/container.
         "systemd.wants=network.target",
         # Make sure we don't load vmw_vmci which messes with virtio vsock.
diff --git a/mkosi/qemu.py b/mkosi/qemu.py
index c270e8d4f..363cc639e 100644
--- a/mkosi/qemu.py
+++ b/mkosi/qemu.py
@@ -1026,7 +1026,7 @@ def run_qemu(args: Args, config: Config) -> None:
                     "-chardev", f"socket,id={sock.name},path={sock}",
                     "-device", f"vhost-user-fs-pci,queue-size=1024,chardev={sock.name},tag=root",
                 ]
-                kcl += ["root=root", "rootfstype=virtiofs", "rw"]
+                kcl += ["root=root", "rootfstype=virtiofs"]
 
         def add_virtiofs_mount(
             sock: Path,