From: Tomas Krizek <tomas.krizek@nic.cz>
Date: Wed, 17 Jun 2020 08:53:18 +0000 (+0200)
Subject: meson: treat -Wattributes as error
X-Git-Tag: v5.1.2~5^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=76daa62637ec4b7d4f138ada67b8c364c80a7870;p=thirdparty%2Fknot-resolver.git

meson: treat -Wattributes as error

Trie relies on __attribute__(cleanup) and if its missing, it could
lead to memory leaks such as:

https://sonarcloud.io/project/issues?id=dns-oarc%3Adnsjit&issues=AXDyskhlrWLe1VCMvmVe&open=AXDyskhlrWLe1VCMvmVe
---

diff --git a/meson.build b/meson.build
index b901d00ba..6c0b990bc 100644
--- a/meson.build
+++ b/meson.build
@@ -116,6 +116,7 @@ add_project_arguments(
   '-Wtype-limits',
   '-Wshadow',
   '-Werror=implicit-function-declaration', # Probably messed up includes; implicit functions are evil!
+  '-Werror=attributes',  # Missing cleanup attribute could lead to memory leaks.
   '-fvisibility=hidden',
   '-DHAVE_ASPRINTF=' + have_asprintf.to_int().to_string(),