From: Viktor Dukhovni <openssl-users@dukhovni.org>
Date: Tue, 18 Feb 2025 14:44:17 +0000 (+1100)
Subject: ssl3_ctrl(): Fix condition in SSL_CTRL_GET_PEER_SIGNATURE_NAME
X-Git-Tag: openssl-3.5.0-alpha1~161
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=76e3fdd0f6b9f838cad263dae35721d43400b5d1;p=thirdparty%2Fopenssl.git

ssl3_ctrl(): Fix condition in SSL_CTRL_GET_PEER_SIGNATURE_NAME

Reviewed-by: Kurt Roeckx <kurt@roeckx.be>
Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/26819)
---

diff --git a/ssl/s3_lib.c b/ssl/s3_lib.c
index ecb7968897e..413ef10e7a4 100644
--- a/ssl/s3_lib.c
+++ b/ssl/s3_lib.c
@@ -3827,7 +3827,7 @@ long ssl3_ctrl(SSL *s, int cmd, long larg, void *parg)
         return ssl_cert_get_cert_store(sc->cert, parg, 1);
 
     case SSL_CTRL_GET_PEER_SIGNATURE_NAME:
-        if (parg == NULL && sc->s3.tmp.peer_sigalg == NULL)
+        if (parg == NULL || sc->s3.tmp.peer_sigalg == NULL)
             return 0;
         *(const char **)parg = sc->s3.tmp.peer_sigalg->name;
         return 1;