From: Greg Hudson <ghudson@mit.edu>
Date: Mon, 2 Jul 2012 17:21:04 +0000 (-0400)
Subject: Fix minor memory leaks in acquire_cred.c
X-Git-Tag: krb5-1.11-alpha1~469
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=76e5a44413c6bdb061263ed7d33ff7b494fa485a;p=thirdparty%2Fkrb5.git

Fix minor memory leaks in acquire_cred.c
---

diff --git a/src/lib/gssapi/krb5/acquire_cred.c b/src/lib/gssapi/krb5/acquire_cred.c
index 1972b1eb26..0527d13202 100644
--- a/src/lib/gssapi/krb5/acquire_cred.c
+++ b/src/lib/gssapi/krb5/acquire_cred.c
@@ -774,10 +774,8 @@ acquire_cred(OM_uint32 *minor_status, gss_name_t desired_name,
 
     if (name != NULL) {
         code = kg_duplicate_name(context, name, &cred->name);
-        if (code) {
-            *minor_status = code;
-            return GSS_S_FAILURE;
-        }
+        if (code)
+            goto krb_error_out;
     }
 
 #ifndef LEAN_CLIENT
@@ -834,6 +832,8 @@ error_out:
     if (cred != NULL) {
         if (cred->ccache)
             krb5_cc_close(context, cred->ccache);
+        if (cred->client_keytab)
+            krb5_kt_close(context, cred->client_keytab);
 #ifndef LEAN_CLIENT
         if (cred->keytab)
             krb5_kt_close(context, cred->keytab);