From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Thu, 6 Jul 2023 22:43:15 +0000 (+1200)
Subject: ldb: Don’t leak ‘el’
X-Git-Tag: tevent-0.16.0~1181
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=77015f3ca03b0fda1677674af444a5005fc02db1;p=thirdparty%2Fsamba.git

ldb: Don’t leak ‘el’

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/lib/ldb/pyldb.c b/lib/ldb/pyldb.c
index 25c7bb17f41..874a64f554e 100644
--- a/lib/ldb/pyldb.c
+++ b/lib/ldb/pyldb.c
@@ -3854,6 +3854,7 @@ static int py_ldb_msg_setitem(PyLdbMessageObject *self, PyObject *name, PyObject
 		ret = ldb_msg_add(pyldb_Message_AsMessage(self), el, el->flags);
 		if (ret != LDB_SUCCESS) {
 			PyErr_SetLdbError(PyExc_LdbError, ret, NULL);
+			talloc_unlink(self->msg, el);
 			return -1;
 		}
 	}