From: John Ferlan <jferlan@redhat.com>
Date: Sun, 3 Nov 2019 12:39:22 +0000 (-0500)
Subject: tests: Add return value check in checkUserInfo
X-Git-Tag: v5.10.0-rc1~404
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=77180d0f703c60ea511a695c12a4f49f186531e2;p=thirdparty%2Flibvirt.git

tests: Add return value check in checkUserInfo

Commit 1c8113f9c added the call to virTypedParamsGetString without
a return value check which caused Coverity to complain especially
since other checks for the same function are made.

Found by Coverity

Signed-off-by: John Ferlan <jferlan@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
---

diff --git a/tests/qemuagenttest.c b/tests/qemuagenttest.c
index cef9ae5fee..ae55086d17 100644
--- a/tests/qemuagenttest.c
+++ b/tests/qemuagenttest.c
@@ -1127,7 +1127,9 @@ checkUserInfo(virTypedParameterPtr params,
 
     snprintf(param_name, VIR_TYPED_PARAM_FIELD_LENGTH,
              "user.%zu.domain", nth);
-    virTypedParamsGetString(params, nparams, param_name, &domain);
+    if (virTypedParamsGetString(params, nparams, param_name, &domain) < 0)
+        return -1;
+
     if (STRNEQ_NULLABLE(expDomain, domain)) {
         virReportError(VIR_ERR_INTERNAL_ERROR,
                        "Expected domain '%s', got '%s'",