From: Antonio Larrosa Date: Fri, 13 Aug 2021 13:13:43 +0000 (+0200) Subject: Add a network pytest mark for tests that use the network (#1669) X-Git-Tag: 0.19.0~4 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=77193b2ab6e7be04bc8793e9fff21c690ac2db12;p=thirdparty%2Fhttpx.git Add a network pytest mark for tests that use the network (#1669) * Add a network pytest mark for tests that use the network Sometimes it's useful to have the tests that use the network marked so they can be skipped easily when we know the network is not available. This is useful for example on SUSE and openSUSE's build servers. When building the httpx packages (actually, any package in the distribution) the network is disabled so we can assure reproducible builds (among other benefits). With this mark, it's easier to skip tests that can not succeed. * Add a better explanation for the network marker Co-authored-by: Florimond Manca <15911462+florimondmanca@users.noreply.github.com> Co-authored-by: Joe Co-authored-by: Florimond Manca <15911462+florimondmanca@users.noreply.github.com> Co-authored-by: Tom Christie --- diff --git a/setup.cfg b/setup.cfg index 2a3bc303..de10fa55 100644 --- a/setup.cfg +++ b/setup.cfg @@ -21,6 +21,7 @@ filterwarnings = default:::uvicorn markers = copied_from(source, changes=None): mark test as copied from somewhere else, along with a description of changes made to accodomate e.g. our test setup + network: marks tests which require network connection. Used in 3rd-party build environments that have network disabled. [coverage:run] omit = venv/*, httpx/_compat.py diff --git a/tests/client/test_proxies.py b/tests/client/test_proxies.py index 6ea4cbe4..2817d202 100644 --- a/tests/client/test_proxies.py +++ b/tests/client/test_proxies.py @@ -122,6 +122,7 @@ def test_transport_for_request(url, proxies, expected): @pytest.mark.asyncio +@pytest.mark.network async def test_async_proxy_close(): try: client = httpx.AsyncClient(proxies={"https://": PROXY_URL}) @@ -130,6 +131,7 @@ async def test_async_proxy_close(): await client.aclose() +@pytest.mark.network def test_sync_proxy_close(): try: client = httpx.Client(proxies={"https://": PROXY_URL}) diff --git a/tests/test_timeouts.py b/tests/test_timeouts.py index 46a8bee8..c7a665c3 100644 --- a/tests/test_timeouts.py +++ b/tests/test_timeouts.py @@ -23,6 +23,7 @@ async def test_write_timeout(server): @pytest.mark.usefixtures("async_environment") +@pytest.mark.network async def test_connect_timeout(server): timeout = httpx.Timeout(None, connect=1e-6)