From: Laine Stump Date: Tue, 21 Feb 2023 06:09:04 +0000 (-0500) Subject: qemu: remove extraneous error log when qemuPasstStart() fails during hotplug X-Git-Tag: v9.1.0-rc1~7 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=771992363e1e85b60fe97dc6a4171d4633402392;p=thirdparty%2Flibvirt.git qemu: remove extraneous error log when qemuPasstStart() fails during hotplug qemuPasstStart() already logs any error that occurs, so having the caller log a generic error message only serves to obscure the actual problem. Fixes: a56f0168d576fa01cec204dc3c67d4d63ab8487f Signed-off-by: Laine Stump Reviewed-by: Michal Privoznik --- diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index b4cddef9f5..da17525824 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -1205,11 +1205,8 @@ qemuDomainAttachNetDevice(virQEMUDriver *driver, case VIR_DOMAIN_NET_TYPE_USER: if (net->backend.type == VIR_DOMAIN_NET_BACKEND_PASST) { - if (qemuPasstStart(vm, net) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, - "%s", _("Failed to start passt")); + if (qemuPasstStart(vm, net) < 0) goto cleanup; - } } else if (!priv->disableSlirp && virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_DBUS_VMSTATE)) {