From: dmose%mozilla.org <>
Date: Mon, 12 Mar 2001 04:08:28 +0000 (+0000)
Subject: Fixed bug 71600: mail would be sent about a given bug iff all flags for stuff changed... 
X-Git-Tag: bugzilla-2.12~45
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=771e38ec238c4814bfbe756d80e991eda60f294b;p=thirdparty%2Fbugzilla.git

Fixed bug 71600: mail would be sent about a given bug iff all flags for stuff changed in a given group were set.  Should have sent mail if any flags for stuff changed in a given group were set.  r=dave@intrec.com,endico@mozilla.org
---

diff --git a/processmail b/processmail
index c1665add75..acd93315c8 100755
--- a/processmail
+++ b/processmail
@@ -785,6 +785,8 @@ sub filterEmailGroup ($$$) {
 
             push(@filteredList,$person);            
 
+            my $detectedOn = 0;
+            
             foreach my $attribute (@emailAttributes) {
 
                 my $matchName = 'email' . $emailGroup . $attribute;
@@ -795,14 +797,23 @@ sub filterEmailGroup ($$$) {
                         next; 
                     }
 
-                    if ( $flagName eq $matchName  && $flagValue ne 'on') {
-                        pop(@filteredList);
+                    if ($flagName eq $matchName){
+                        if ($flagValue eq 'on') {
+                            $detectedOn = 1;
+                        }
                     }
 
                 } # for each userFlag
 
             } # for each email attribute
 
+            # if the current flag hasn't been detected on at least once, 
+            # this person gets filtered from this group.
+            #
+            if (! $detectedOn) {
+                pop(@filteredList);
+            }
+
             # check to see if the person was removed from this email 
             # group.