From: Dmitry Belyavskiy <beldmit@gmail.com>
Date: Mon, 1 Aug 2022 10:33:39 +0000 (+0200)
Subject: Avoid resource leaks in do_ssl3_write
X-Git-Tag: openssl-3.2.0-alpha1~2306
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=771fef7793ae572be7567e408a07bfefe6a09ea0;p=thirdparty%2Fopenssl.git

Avoid resource leaks in do_ssl3_write

Thanks Matt for pointing on it

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/18924)
---

diff --git a/ssl/record/rec_layer_s3.c b/ssl/record/rec_layer_s3.c
index af539a0ea1a..05b49a21e3a 100644
--- a/ssl/record/rec_layer_s3.c
+++ b/ssl/record/rec_layer_s3.c
@@ -876,7 +876,7 @@ int do_ssl3_write(SSL_CONNECTION *s, int type, const unsigned char *buf,
             eivlen = EVP_CIPHER_CTX_get_iv_length(s->enc_write_ctx);
             if (eivlen < 0) {
                 SSLfatal(s, SSL_AD_INTERNAL_ERROR, SSL_R_LIBRARY_BUG);
-                return -1;
+                goto err;
 	    }
             if (eivlen <= 1)
                 eivlen = 0;