From: Pavel Hrdina <phrdina@redhat.com>
Date: Mon, 4 Oct 2021 18:18:49 +0000 (+0200)
Subject: qemu_snapshot: create: move saving metadata to separate function
X-Git-Tag: v8.0.0-rc1~457
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=773bf7c8462718e82ee375d27530f372fc6725a7;p=thirdparty%2Flibvirt.git

qemu_snapshot: create: move saving metadata to separate function

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c
index 32eb2eeb89..95c1e83f2d 100644
--- a/src/qemu/qemu_snapshot.c
+++ b/src/qemu/qemu_snapshot.c
@@ -1693,6 +1693,27 @@ qemuSnapshotCreateAlignDisks(virDomainObj *vm,
 }
 
 
+static int
+qemuSnapshotCreateWriteMetadata(virDomainObj *vm,
+                                virDomainMomentObj *snap,
+                                virQEMUDriver *driver,
+                                virQEMUDriverConfig *cfg)
+{
+    if (qemuDomainSnapshotWriteMetadata(vm, snap,
+                                        driver->xmlopt,
+                                        cfg->snapshotDir) < 0) {
+        virReportError(VIR_ERR_INTERNAL_ERROR,
+                       _("unable to save metadata for snapshot %s"),
+                       snap->def->name);
+        return -1;
+    }
+
+    virDomainSnapshotLinkParent(vm->snapshots, snap);
+
+    return 0;
+}
+
+
 virDomainSnapshotPtr
 qemuSnapshotCreateXML(virDomainPtr domain,
                       virDomainObj *vm,
@@ -1821,20 +1842,14 @@ qemuSnapshotCreateXML(virDomainPtr domain,
         if (!redefine || (flags & VIR_DOMAIN_SNAPSHOT_CREATE_CURRENT))
             qemuSnapshotSetCurrent(vm, snap);
 
-        if (qemuDomainSnapshotWriteMetadata(vm, snap,
-                                            driver->xmlopt,
-                                            cfg->snapshotDir) < 0) {
+        if (qemuSnapshotCreateWriteMetadata(vm, snap, driver, cfg) < 0) {
             /* if writing of metadata fails, error out rather than trying
              * to silently carry on without completing the snapshot */
             virObjectUnref(snapshot);
             snapshot = NULL;
-            virReportError(VIR_ERR_INTERNAL_ERROR,
-                           _("unable to save metadata for snapshot %s"),
-                           snap->def->name);
             goto endjob;
         }
 
-        virDomainSnapshotLinkParent(vm->snapshots, snap);
         snap = NULL;
     }