From: Karel Zak <kzak@redhat.com>
Date: Mon, 16 Mar 2015 10:51:05 +0000 (+0100)
Subject: logger: fix rfc5424 format crash
X-Git-Tag: v2.27-rc1~358
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=773df0fa2f6c12581cc8649a08b9d825456a247c;p=thirdparty%2Futil-linux.git

logger: fix rfc5424 format crash

$ logger --rfc5424=notq message
Segmentation fault (core dumped)

Reported-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Karel Zak <kzak@redhat.com>
---

diff --git a/misc-utils/logger.c b/misc-utils/logger.c
index 8255ce6b95..10b23dc8f0 100644
--- a/misc-utils/logger.c
+++ b/misc-utils/logger.c
@@ -449,7 +449,8 @@ static void syslog_rfc5424_header(struct logger_ctl *const ctl)
 #endif
 			xasprintf(&structured_data,
 				 "[timeQuality tzKnown=\"1\" isSynced=\"0\"]");
-	}
+	} else
+		structured_data = xstrdup(NILVALUE);
 
 	xasprintf(&ctl->hdr, "<%d>1 %s %s %s %s %s %s ",
 		ctl->pri,