From: Amos Jeffries <squid3@treenet.co.nz>
Date: Sat, 22 Mar 2008 04:11:35 +0000 (+1200)
Subject: Author: Massimo Zito <zmax.linkedin at gmail dot com>
X-Git-Tag: SQUID_3_0_STABLE3~4^2~6
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7746f6ded66f001f22ee028e43f08b989827dc64;p=thirdparty%2Fsquid.git

Author: Massimo Zito <zmax.linkedin at gmail dot com>
squid_radius_auth failed to process more than 256 requests

The radius request-id field is a unsigned char, but the internal request_id
counter was a integer causing mismatch after 256 queries.
---

diff --git a/helpers/basic_auth/squid_radius_auth/Changelog b/helpers/basic_auth/squid_radius_auth/Changelog
index 05d5cb041c..7560d92a8a 100644
--- a/helpers/basic_auth/squid_radius_auth/Changelog
+++ b/helpers/basic_auth/squid_radius_auth/Changelog
@@ -1,3 +1,6 @@
+1.10: - Fix processing of more than 256 queries
+      - Send a dummy NAS-Port-Type attribute
+      - Documentation cleanup
 1.09: - RADIUS protocol fixes by Henrik Nordstrom <hno@squid-cache.org>
       - Corrected how retransmits & timeouts is handled
       - The shared secret now verified properly
diff --git a/helpers/basic_auth/squid_radius_auth/squid_rad_auth.c b/helpers/basic_auth/squid_radius_auth/squid_rad_auth.c
index 2b12f18fdb..960cf65ed3 100644
--- a/helpers/basic_auth/squid_radius_auth/squid_rad_auth.c
+++ b/helpers/basic_auth/squid_radius_auth/squid_rad_auth.c
@@ -105,7 +105,7 @@ static int i_recv_buffer[2048];
 static char *send_buffer = (char *) i_send_buffer;
 static char *recv_buffer = (char *) i_recv_buffer;
 static int sockfd;
-static int request_id;
+static u_char request_id;
 static char vector[AUTH_VECTOR_LEN];
 static char secretkey[MAXPASS + 1] = "";
 static char server[MAXLINE] = "";