From: Ján Tomko <jtomko@redhat.com>
Date: Tue, 16 Jul 2019 08:37:03 +0000 (+0200)
Subject: qemu: command: use VIR_AUTOFREE in qemuBuildFSDevCommandLine
X-Git-Tag: v5.6.0-rc1~194
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=77570e2600d2f4ac62b9dc0af190bf05c0f9c6b4;p=thirdparty%2Flibvirt.git

qemu: command: use VIR_AUTOFREE in qemuBuildFSDevCommandLine

Introduce two separate variables instead of reusing the same one
for clarity.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Acked-by: Peter Krempa <pkrempa@redhat.com>
---

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 02a6642207..ef90dc5044 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -2807,22 +2807,21 @@ qemuBuildFSDevCommandLine(virCommandPtr cmd,
                           const virDomainDef *def,
                           virQEMUCapsPtr qemuCaps)
 {
-    char *optstr;
+    VIR_AUTOFREE(char *) fsdevstr = NULL;
+    VIR_AUTOFREE(char *) devicestr = NULL;
 
     virCommandAddArg(cmd, "-fsdev");
-    if (!(optstr = qemuBuildFSStr(fs)))
+    if (!(fsdevstr = qemuBuildFSStr(fs)))
         return -1;
-    virCommandAddArg(cmd, optstr);
-    VIR_FREE(optstr);
+    virCommandAddArg(cmd, fsdevstr);
 
     if (qemuCommandAddExtDevice(cmd, &fs->info) < 0)
         return -1;
 
     virCommandAddArg(cmd, "-device");
-    if (!(optstr = qemuBuildFSDevStr(def, fs, qemuCaps)))
+    if (!(devicestr = qemuBuildFSDevStr(def, fs, qemuCaps)))
         return -1;
-    virCommandAddArg(cmd, optstr);
-    VIR_FREE(optstr);
+    virCommandAddArg(cmd, devicestr);
 
     return 0;
 }