From: Marc Schumann <wurblzap@gmail.com>
Date: Sat, 14 Apr 2012 16:06:14 +0000 (+0200)
Subject: Change columns: empty buttons when images turned off.
X-Git-Tag: bugzilla-4.3.1~15
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=778ea7db809b441b3efede0b135bae8fa128bcc7;p=thirdparty%2Fbugzilla.git

Change columns: empty buttons when images turned off.
r/a=LpSolit

https://bugzilla.mozilla.org/show_bug.cgi?id=474747
---

diff --git a/skins/standard/global.css b/skins/standard/global.css
index 066fa6b77c..905a971589 100644
--- a/skins/standard/global.css
+++ b/skins/standard/global.css
@@ -392,6 +392,12 @@ dl dl > dt {
     white-space: normal !important;
 }
 
+/* Arrow buttons are buttons with only &uarr;, &darr;, &larr; or &rarr; on
+ * them. We want these to look a little less spidery. */
+.arrow_button {
+    font-size: 150%;
+}
+
 /* Style of the attachment table and time tracking table */
 #attachment_table {
     border-collapse: collapse;
@@ -543,30 +549,3 @@ input.required, select.required, span.required_explanation {
     border: 2px solid #B70000;
     background-color: #FFEBEB;
 }
-
-/*****************/
-/* colchange.cgi */
-/*****************/
-
-.image_button {
-    background-repeat: no-repeat;
-    background-position: center center;
-    width: 30px;
-    height: 20px;
-}
-
-#select_button {
-    background-image: url(global/right.png);
-}
-
-#deselect_button {
-    background-image: url(global/left.png);
-}
-
-#up_button {
-    background-image: url(global/up.png);
-}
-
-#down_button {
-    background-image: url(global/down.png);
-}
diff --git a/skins/standard/global/down.png b/skins/standard/global/down.png
deleted file mode 100644
index 78a9e631a4..0000000000
Binary files a/skins/standard/global/down.png and /dev/null differ
diff --git a/skins/standard/global/left.png b/skins/standard/global/left.png
deleted file mode 100644
index f8cb2b2ddd..0000000000
Binary files a/skins/standard/global/left.png and /dev/null differ
diff --git a/skins/standard/global/right.png b/skins/standard/global/right.png
deleted file mode 100644
index d02b707a64..0000000000
Binary files a/skins/standard/global/right.png and /dev/null differ
diff --git a/skins/standard/global/up.png b/skins/standard/global/up.png
deleted file mode 100644
index 240d483df7..0000000000
Binary files a/skins/standard/global/up.png and /dev/null differ
diff --git a/template/en/default/list/change-columns.html.tmpl b/template/en/default/list/change-columns.html.tmpl
index b823d497d1..17d711eec8 100644
--- a/template/en/default/list/change-columns.html.tmpl
+++ b/template/en/default/list/change-columns.html.tmpl
@@ -41,8 +41,7 @@
       <tr>
         <th><div id="avail_header" class="bz_default_hidden">Available Columns</div></th>
         <th></th>
-        <th>Selected Columns</th>
-        <th></th>
+        <th colspan="2">Selected Columns</th>
       </tr>
       <tr>
         <td>
@@ -52,11 +51,13 @@
           </select>
         </td>
         <td>
-          <input class="image_button bz_default_hidden" type="button" 
-                 id="select_button" name="select" onclick="move_select()">
+          <button type="button" id="select_button" name="select"
+                  class="bz_default_hidden arrow_button"
+                  onclick="move_select()">&rarr;</button>
           <br><br>
-          <input class="image_button bz_default_hidden" type="button" 
-                 id="deselect_button" name="deselect" onclick="move_deselect()">
+          <button type="button" id="deselect_button" name="deselect"
+                  class="bz_default_hidden arrow_button"
+                  onclick="move_deselect()">&larr;</button>
         </td>
         <td>
           <select name="selected_columns" id="selected_columns" 
@@ -77,11 +78,13 @@
           </select>
         </td>
         <td>
-          <input class="image_button bz_default_hidden" type="button" 
-                 id="up_button" name="up" onclick="move_up()">
+          <button type="button" id="up_button" name="up"
+                  class="bz_default_hidden arrow_button"
+                  onclick="move_up()">&uarr;</button>
           <br><br>
-          <input class="image_button bz_default_hidden" type="button"
-                 id="down_button" name="down" onclick="move_down()">
+          <button type="button" id="down_button" name="down"
+                  class="bz_default_hidden arrow_button"
+                  onclick="move_down()">&darr;</button>
         </td>
       </tr>
     </table>