From: Christian Brauner <christian.brauner@ubuntu.com>
Date: Wed, 15 Apr 2020 11:59:19 +0000 (+0200)
Subject: commands: add additional check to lxc_cmd_sock_get_state()
X-Git-Tag: lxc-5.0.0~451^2~4
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7792a5b60f7949d1a41db95f1ea2a7a6b89d9a3f;p=thirdparty%2Flxc.git

commands: add additional check to lxc_cmd_sock_get_state()

to please Coverity.

Fixes: Coverity 1461732.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
---

diff --git a/src/lxc/commands_utils.c b/src/lxc/commands_utils.c
index 2f2670d74..2af722ca1 100644
--- a/src/lxc/commands_utils.c
+++ b/src/lxc/commands_utils.c
@@ -62,11 +62,14 @@ int lxc_cmd_sock_get_state(const char *name, const char *lxcpath,
 
 	ret = lxc_cmd_add_state_client(name, lxcpath, states, &state_client_fd);
 	if (ret < 0)
-		return -1;
+		return ret_errno(EINVAL);
 
 	if (ret < MAX_STATE)
 		return ret;
 
+	if (state_client_fd < 0)
+		return ret_errno(EBADF);
+
 	return lxc_cmd_sock_rcv_state(state_client_fd, timeout);
 }