From: Volker Lendecke <vl@samba.org>
Date: Wed, 17 Sep 2025 13:05:52 +0000 (-0700)
Subject: smbd: Move a variable declaration closer to its use
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=779aed4ac0e9b608a18d3bff2a664bbf2e8c2a9a;p=thirdparty%2Fsamba.git

smbd: Move a variable declaration closer to its use

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
---

diff --git a/source3/smbd/smb2_nttrans.c b/source3/smbd/smb2_nttrans.c
index 37d49f8289a..17eeb93fa36 100644
--- a/source3/smbd/smb2_nttrans.c
+++ b/source3/smbd/smb2_nttrans.c
@@ -287,7 +287,6 @@ NTSTATUS copy_internals(TALLOC_CTX *ctx,
 	off_t ret=-1;
 	NTSTATUS status = NT_STATUS_OK;
 	struct smb_filename *parent = NULL;
-	struct smb_filename *pathref = NULL;
 
 	if (!CAN_WRITE(conn)) {
 		status = NT_STATUS_MEDIA_WRITE_PROTECTED;
@@ -414,6 +413,8 @@ NTSTATUS copy_internals(TALLOC_CTX *ctx,
 		goto out;
 	}
 	if (smb_fname_dst->fsp == NULL) {
+		struct smb_filename *pathref = NULL;
+
 		status = synthetic_pathref(parent,
 					conn->cwd_fsp,
 					smb_fname_dst->base_name,
@@ -430,6 +431,7 @@ NTSTATUS copy_internals(TALLOC_CTX *ctx,
 		}
 		file_set_dosmode(conn, pathref, fattr, parent, false);
 		smb_fname_dst->st.st_ex_mode = pathref->st.st_ex_mode;
+		TALLOC_FREE(pathref);
 	} else {
 		file_set_dosmode(conn, smb_fname_dst, fattr, parent, false);
 	}