From: Volker Lendecke <vl@samba.org>
Date: Wed, 14 Aug 2019 06:39:10 +0000 (+0200)
Subject: lib: CID 1452289: API usage errors  (USE_AFTER_FREE)
X-Git-Tag: tdb-1.4.2~149
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=77ae0429c91c03163eaf7545888a7ca7d76ace11;p=thirdparty%2Fsamba.git

lib: CID 1452289: API usage errors  (USE_AFTER_FREE)

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
---

diff --git a/lib/util/tiniparser.c b/lib/util/tiniparser.c
index dbd1c058b0d..428ccff8a63 100644
--- a/lib/util/tiniparser.c
+++ b/lib/util/tiniparser.c
@@ -328,7 +328,6 @@ struct tiniparser_dictionary *tiniparser_load_stream(FILE *fp)
 
 	d = malloc(sizeof(struct tiniparser_dictionary));
 	if (d == NULL) {
-		fclose(fp);
 		return NULL;
 	}
 	d->section_list = NULL;