From: Matthew Jordan Date: Tue, 12 Mar 2013 16:23:16 +0000 (+0000) Subject: Include the Username field in SIP Registry events when Status is registered X-Git-Tag: 11.4.0-rc1~28 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=77ca918044609ae5acc960a65028b93d5263c8f3;p=thirdparty%2Fasterisk.git Include the Username field in SIP Registry events when Status is registered In ASTERISK-17888, the AMI Registry event during SIP registrations was supposed to include the Username field. Somehow, one of the events was missed. This patch corrects that - the Username field should be included in all AMI Registry events involving SIP registrations. (issue ASTERISK-17888) (closes issue ASTERISK-21201) Reported by: Dmitriy Serov patches: chan_sip.c.diff uploaded by Dmitriy Serov (license 6479) ........ Merged revisions 382847 from http://svn.asterisk.org/svn/asterisk/branches/1.8 git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@382848 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- diff --git a/UPGRADE.txt b/UPGRADE.txt index df4216f695..1bc7e1eb4a 100644 --- a/UPGRADE.txt +++ b/UPGRADE.txt @@ -27,6 +27,10 @@ From 11.3 to 11.4: if a denoiser is attached to the channel; this option gives them the ability to remove the denoiser without having to unload func_speex. +* The Registry AMI event for SIP registrations will now always include the + Username field. A previous bug fix missed an instance where it was not + included; that has been corrected in this release. + From 11.2.0 to 11.2.1: * Asterisk would previously not output certain error messages when a remote console attempted to connect to Asterisk and no instance of Asterisk was diff --git a/channels/chan_sip.c b/channels/chan_sip.c index c2625fc60a..63e53729ea 100644 --- a/channels/chan_sip.c +++ b/channels/chan_sip.c @@ -23234,7 +23234,7 @@ static int handle_response_register(struct sip_pvt *p, int resp, const char *res r->regstate = REG_STATE_REGISTERED; r->regtime = ast_tvnow(); /* Reset time of last successful registration */ - manager_event(EVENT_FLAG_SYSTEM, "Registry", "ChannelType: SIP\r\nDomain: %s\r\nStatus: %s\r\n", r->hostname, regstate2str(r->regstate)); + manager_event(EVENT_FLAG_SYSTEM, "Registry", "ChannelType: SIP\r\nUsername: %s\r\nDomain: %s\r\nStatus: %s\r\n", r->username, r->hostname, regstate2str(r->regstate)); r->regattempts = 0; ast_debug(1, "Registration successful\n"); if (r->timeout > -1) {