From: Shijin Bose (shibose) <shibose@cisco.com>
Date: Thu, 31 Oct 2024 13:09:47 +0000 (+0000)
Subject: Pull request #4499: appid: unit-test added for is_service_over_quic
X-Git-Tag: 3.5.1.0~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=77d49772974a0a93bf53eb59a096e68399421afa;p=thirdparty%2Fsnort3.git

Pull request #4499: appid: unit-test added for is_service_over_quic

Merge in SNORT/snort3 from ~SHIBOSE/snort3:quic_white_list_mock to master

Squashed commit of the following:

commit 4188e83312d24a55eaefd8495f8f2f8da3e7830b
Author: shibose <shibose@cisco.com>
Date:   Wed Oct 30 12:54:38 2024 +0000

    appid: unit-test added for is_service_over_quic
---

diff --git a/src/network_inspectors/appid/appid_session_api.cc b/src/network_inspectors/appid/appid_session_api.cc
index 2108a6c44..f8ff036a3 100644
--- a/src/network_inspectors/appid/appid_session_api.cc
+++ b/src/network_inspectors/appid/appid_session_api.cc
@@ -227,7 +227,7 @@ void AppIdSessionApi::get_app_id(AppId* service, AppId* client,
 
 bool AppIdSessionApi::is_service_over_quic() const
 {
-    switch(get_service_app_id())
+    switch (get_service_app_id())
     {
         case APP_ID_HTTP3:
         case APP_ID_QUIC:
diff --git a/src/network_inspectors/appid/test/appid_session_api_test.cc b/src/network_inspectors/appid/test/appid_session_api_test.cc
index 7b94f9cee..ee0b2881a 100644
--- a/src/network_inspectors/appid/test/appid_session_api_test.cc
+++ b/src/network_inspectors/appid/test/appid_session_api_test.cc
@@ -118,6 +118,24 @@ TEST(appid_session_api, get_client_app_id)
     CHECK_EQUAL(APP_ID_NONE, id);
 }
 
+TEST(appid_session_api, is_service_over_quic)
+{
+    SfIp ip{};
+    AppIdSession asd(IpProtocol::UDP, &ip, 1492, dummy_appid_inspector, odpctxt, 0
+    #ifndef DISABLE_TENANT_ID
+    ,0
+    #endif
+    );
+    asd.flow = &flow;
+    AppidChangeBits change_bits;
+    asd.set_ss_application_ids(APP_ID_QUIC, APPID_UT_ID, APPID_UT_ID, APPID_UT_ID, APPID_UT_ID, change_bits);
+    CHECK_EQUAL(asd.get_api().is_service_over_quic(), true);
+
+    asd.set_ss_application_ids(APP_ID_DNS, APPID_UT_ID, APPID_UT_ID, APPID_UT_ID, APPID_UT_ID, change_bits);
+    CHECK_EQUAL(asd.get_api().is_service_over_quic(), false);
+    delete &asd.get_api();
+}
+
 TEST(appid_session_api, get_client_app_id_with_eve_for_http2)
 {
     SfIp ip{};