From: Roel van Meer Date: Fri, 22 Aug 2014 13:11:04 +0000 (+0200) Subject: Don't discard result of checking grouptype X-Git-Tag: samba-4.0.22~8 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=77e7db987f5bc1fa8a452fd2de1c4564e82fe4b7;p=thirdparty%2Fsamba.git Don't discard result of checking grouptype The pdb_samba_dsdb_getgrfilter() function first determines the security type of a group and sets map->sid_name_use accordingly. A little later, this variable is set again, undoing the previous work. https://bugzilla.samba.org/show_bug.cgi?id=10777 Reviewed-by: Jeremy Allison Reviewed-by: Simo Sorce Autobuild-User(master): Jeremy Allison Autobuild-Date(master): Sat Aug 23 02:48:52 CEST 2014 on sn-devel-104 --- diff --git a/source3/passdb/pdb_samba_dsdb.c b/source3/passdb/pdb_samba_dsdb.c index 2e61e0d748f..3b35bff6b6e 100644 --- a/source3/passdb/pdb_samba_dsdb.c +++ b/source3/passdb/pdb_samba_dsdb.c @@ -920,8 +920,6 @@ static NTSTATUS pdb_samba_dsdb_getgrfilter(struct pdb_methods *m, GROUP_MAP *map return NT_STATUS_INTERNAL_DB_CORRUPTION; } - map->sid_name_use = SID_NAME_DOM_GRP; - ZERO_STRUCT(id_map); id_map.sid = sid; id_maps[0] = &id_map;