From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Tue, 31 Oct 2023 09:44:00 +0000 (+0100)
Subject: dnsdist: Silence a false positive reported by Coverity as CID 404742
X-Git-Tag: rec-5.0.0-beta1~22^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=781f36d6b835720f65e28c17808760373d2497a4;p=thirdparty%2Fpdns.git

dnsdist: Silence a false positive reported by Coverity as CID 404742
---

diff --git a/pdns/dnsdistdist/doh.cc b/pdns/dnsdistdist/doh.cc
index a3ccd80160..47c6d904f2 100644
--- a/pdns/dnsdistdist/doh.cc
+++ b/pdns/dnsdistdist/doh.cc
@@ -812,6 +812,10 @@ static void processDOHQuery(DOHUnitUniquePtr&& unit, bool inMainThread = false)
 
       /* this moves du->ids, careful! */
       auto cpq = std::make_unique<DoHCrossProtocolQuery>(std::move(unit), false);
+      if (!cpq) {
+        // make linters happy
+        return;
+      }
       cpq->query.d_proxyProtocolPayload = std::move(proxyProtocolPayload);
 
       if (downstream->passCrossProtocolQuery(std::move(cpq))) {