From: Frederic Lecaille <flecaille@haproxy.com>
Date: Fri, 29 Nov 2024 13:39:48 +0000 (+0100)
Subject: BUILD: quic: fix a build error about an non initialized timestamp
X-Git-Tag: v3.2-dev1~60
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7868dc9c45aeb29774baac98711f563755b610d6;p=thirdparty%2Fhaproxy.git

BUILD: quic: fix a build error about an non initialized timestamp

This is to please a non identified compilers which complains about an hypothetic
<time_ns> variable which would be not initialized even if this is the case only
when it is not used.

This build issue arrived with this commit:
	BUG/MINOR: improve BBR throughput on very fast links

Should be backported to 3.1 with this previous commit.
---

diff --git a/src/quic_rx.c b/src/quic_rx.c
index b675e720b8..b333c13ff9 100644
--- a/src/quic_rx.c
+++ b/src/quic_rx.c
@@ -432,13 +432,10 @@ static void qc_notify_cc_of_newly_acked_pkts(struct quic_conn *qc,
 	struct quic_cc_drs *drs =
 		p->cc.algo->get_drs ? p->cc.algo->get_drs(&p->cc) : NULL;
 	unsigned int bytes_delivered = 0, pkt_delivered = 0;
-	uint64_t time_ns;
+	uint64_t time_ns = task_mono_time();
 
 	TRACE_ENTER(QUIC_EV_CONN_PRSAFRM, qc);
 
-	if (drs)
-		time_ns = task_mono_time();
-
 	list_for_each_entry_safe(pkt, tmp, newly_acked_pkts, list) {
 		pkt->pktns->tx.in_flight -= pkt->in_flight_len;
 		p->prep_in_flight -= pkt->in_flight_len;