From: Aki Tuomi <aki.tuomi@dovecot.fi>
Date: Wed, 1 Nov 2017 16:04:57 +0000 (+0200)
Subject: fts-lucene: Do not clobber return value
X-Git-Tag: 2.3.0.rc1~615
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=787bbd436a27587393bbcafa23f307f4ee3635b1;p=thirdparty%2Fdovecot%2Fcore.git

fts-lucene: Do not clobber return value

Found by scanbuild
---

diff --git a/src/plugins/fts-lucene/fts-backend-lucene.c b/src/plugins/fts-lucene/fts-backend-lucene.c
index e839838b10..9b8e6e5bfe 100644
--- a/src/plugins/fts-lucene/fts-backend-lucene.c
+++ b/src/plugins/fts-lucene/fts-backend-lucene.c
@@ -263,6 +263,7 @@ fts_backend_lucene_update_deinit(struct fts_backend_update_context *_ctx)
 	if (ctx->expunge_ctx != NULL) {
 		if (fts_expunge_log_append_commit(&ctx->expunge_ctx) < 0) {
 			struct stat st;
+			ret = -1;
 
 			if (stat(backend->dir_path, &st) < 0 && errno == ENOENT) {
 				/* lucene-indexes directory doesn't even exist,
@@ -271,7 +272,6 @@ fts_backend_lucene_update_deinit(struct fts_backend_update_context *_ctx)
 				(void)lucene_index_rescan(backend->index);
 				ret = 0;
 			}
-			ret = -1;
 		}
 	}