From: Günther Deschner <gd@samba.org>
Date: Sat, 8 May 2010 00:16:37 +0000 (+0200)
Subject: s3-net: Fix Bug #7417. 'net rpc user password' can set the wrong password.
X-Git-Tag: samba-3.6.0pre1~2142
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7887d99a60387e93ce5ce4a3bfe9117939d1e4c8;p=thirdparty%2Fsamba.git

s3-net: Fix Bug #7417. 'net rpc user password' can set the wrong password.

Guenther
---

diff --git a/source3/utils/net_rpc.c b/source3/utils/net_rpc.c
index 0fd693e582a..253e9771c2b 100644
--- a/source3/utils/net_rpc.c
+++ b/source3/utils/net_rpc.c
@@ -845,8 +845,11 @@ static int rpc_user_password(struct net_context *c, int argc, const char **argv)
 		if (ret == -1) {
 			return -1;
 		}
-		u1003.usri1003_password = getpass(prompt);
+		u1003.usri1003_password = talloc_strdup(c, getpass(prompt));
 		SAFE_FREE(prompt);
+		if (u1003.usri1003_password == NULL) {
+			return -1;
+		}
 	}
 
 	status = NetUserSetInfo(c->opt_host, argv[0], 1003, (uint8_t *)&u1003, &parm_err);