From: Katerina Kubecova <katerina.kubecova@nic.cz>
Date: Wed, 13 Nov 2024 14:45:09 +0000 (+0100)
Subject: Neighbor locking: forgotten neighbors to unlink are actually a bug.
X-Git-Tag: v3.0.0~84
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7889f0c25b3457fe1df464de3c109c3e59c1493f;p=thirdparty%2Fbird.git

Neighbor locking: forgotten neighbors to unlink are actually a bug.

These may cause runaway pointers.
---

diff --git a/nest/iface.c b/nest/iface.c
index 3d1483ace..897948acc 100644
--- a/nest/iface.c
+++ b/nest/iface.c
@@ -684,7 +684,7 @@ iface_unsubscribe(struct iface_subscription *s)
 
   WALK_TLIST_DELSAFE(proto_neigh, n, &p->neighbors)
   {
-    log(L_WARN "%s: Unlinking forgotten neighbor %I", p->name, n->addr);
+    bug("%s: Unlinking forgotten neighbor %I", p->name, n->addr);
     neigh_unlink_locked(n);
   }