From: Nick Porter <nick@portercomputing.co.uk>
Date: Tue, 16 Dec 2025 08:26:56 +0000 (+0000)
Subject: Correct handling of nested attributes when reading detail files
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=78c4d2a8547a60e5ddc82f18cff7dbed0ba7dcc4;p=thirdparty%2Ffreeradius-server.git

Correct handling of nested attributes when reading detail files
---

diff --git a/src/listen/detail/proto_detail.c b/src/listen/detail/proto_detail.c
index ecf0755dd84..edfe309cf67 100644
--- a/src/listen/detail/proto_detail.c
+++ b/src/listen/detail/proto_detail.c
@@ -317,11 +317,6 @@ static int mod_decode(void const *instance, request_t *request, uint8_t *const d
 			goto next;
 		}
 
-		/*
-		 *	Ensure temporary list is empty before each use
-		 */
-		fr_pair_list_free(&tmp_list);
-
 		/*
 		 *	Reinitialize every time.
 		 *
@@ -372,9 +367,7 @@ static int mod_decode(void const *instance, request_t *request, uint8_t *const d
 			RWDEBUG("Ignoring line %d - %s", lineno, p);
 
 		} else {
-
 			vp = fr_pair_list_head(&tmp_list);
-			fr_pair_list_append(&request->request_pairs, &tmp_list);
 		}
 
 		/*
@@ -397,6 +390,8 @@ static int mod_decode(void const *instance, request_t *request, uint8_t *const d
 		while ((p < end) && (*p)) p++;
 	}
 
+	fr_pair_list_append(&request->request_pairs, &tmp_list);
+
 	/*
 	 *	Let the app_io take care of populating additional fields in the request
 	 */