From: Noel Power Date: Wed, 14 Aug 2019 13:31:07 +0000 (+0100) Subject: libcli/auth: clang: Fix 'Value stored to 'status' is never read' X-Git-Tag: tevent-0.10.1~130 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=78ca70925ca00ae96065db4fd7a963cb999f2f3d;p=thirdparty%2Fsamba.git libcli/auth: clang: Fix 'Value stored to 'status' is never read' Fixes: libcli/auth/netlogon_creds_cli.c:2622:2: warning: Value stored to 'status' is never read <--[clang] status = netlogon_creds_decrypt_samlogon_validation(&state->tmp_creds, ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 warning generated. Signed-off-by: Noel Power Reviewed-by: Gary Lockyer --- diff --git a/libcli/auth/netlogon_creds_cli.c b/libcli/auth/netlogon_creds_cli.c index 50a5f50a57d..c5a100c3c0e 100644 --- a/libcli/auth/netlogon_creds_cli.c +++ b/libcli/auth/netlogon_creds_cli.c @@ -2622,7 +2622,7 @@ static void netlogon_creds_cli_LogonSamLogon_done(struct tevent_req *subreq) status = netlogon_creds_decrypt_samlogon_validation(&state->tmp_creds, state->validation_level, state->validation); - if (tevent_req_nterror(req, result)) { + if (tevent_req_nterror(req, status)) { netlogon_creds_cli_LogonSamLogon_cleanup(req, result); return; }