From: Alexander Wetzel <alexander@wetzel-home.de>
Date: Fri, 20 Dec 2019 19:21:25 +0000 (+0100)
Subject: DPP: Fix a memory leak on an error path
X-Git-Tag: hostap_2_10~2140
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=78d338d1b1206844e4f0c3e03d227144044830e9;p=thirdparty%2Fhostap.git

DPP: Fix a memory leak on an error path

Fix a memory leak exposed by the dpp_own_config_sign_fail test.

Fixes: 52d469de1112 ("DPP2: Support multiple Config Objects in Enrollee")
Signed-off-by: Alexander Wetzel <alexander@wetzel-home.de>
---

diff --git a/src/common/dpp.c b/src/common/dpp.c
index 0d0c47ec8..8c873fdf0 100644
--- a/src/common/dpp.c
+++ b/src/common/dpp.c
@@ -6859,8 +6859,11 @@ int dpp_configurator_own_config(struct dpp_authentication *auth,
 	dpp_copy_csign(&auth->conf_obj[0], auth->conf->csign);
 
 	conf_obj = dpp_build_conf_obj(auth, ap, 0);
-	if (!conf_obj)
+	if (!conf_obj) {
+		wpabuf_free(auth->conf_obj[0].c_sign_key);
+		auth->conf_obj[0].c_sign_key = NULL;
 		goto fail;
+	}
 	ret = dpp_parse_conf_obj(auth, wpabuf_head(conf_obj),
 				 wpabuf_len(conf_obj));
 fail: