From: Pavel Filipenský <pfilipensky@samba.org>
Date: Wed, 26 Nov 2025 07:06:21 +0000 (+0100)
Subject: lib/util: Add tests for the new secure data_blob_..._s() functions
X-Git-Tag: tdb-1.4.15~209
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=78ec0e4f6cdedc17becdfb8f9e35a5550d85ed04;p=thirdparty%2Fsamba.git

lib/util: Add tests for the new secure data_blob_..._s() functions

Signed-off-by: Pavel Filipenský <pfilipensky@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
---

diff --git a/lib/util/tests/data_blob.c b/lib/util/tests/data_blob.c
index b247ed25b08..423d4d1edee 100644
--- a/lib/util/tests/data_blob.c
+++ b/lib/util/tests/data_blob.c
@@ -54,6 +54,58 @@ static bool test_zero(struct torture_context *tctx)
 	return true;
 }
 
+static bool test_zero_s(struct torture_context *tctx)
+{
+	DATA_BLOB z = data_blob_talloc_zero_s(tctx, 4);
+	int i;
+	uint8_t *p;
+
+	torture_assert_int_equal(tctx, z.length, 4, "length");
+	for (i = 0; i < z.length; i++)
+		torture_assert_int_equal(tctx, z.data[i], 0, "contents");
+	z.data[0] = 'a';
+	p = z.data; /* store pointer that will be freed */
+	torture_assert_int_equal(tctx, *p, 'a', "contents");
+	data_blob_free(&z);
+	/* coverity[use_after_free] */
+	torture_assert_int_equal(tctx, *p, 0, "contents");
+	return true;
+}
+
+static bool test_talloc_s(struct torture_context *tctx)
+{
+	DATA_BLOB z = data_blob_talloc_s(tctx, "hello", 5);
+	int i;
+	uint8_t *p;
+
+	torture_assert_int_equal(tctx, z.length, 5, "length");
+	for (i = 0; i < z.length; i++)
+		torture_assert_int_not_equal(tctx, z.data[i], 0, "data");
+	p = z.data; /* store pointer that will be freed */
+	data_blob_free(&z);
+	for (i = 0; i < 5; i++)
+		/* coverity[use_after_free] */
+		torture_assert_int_equal(tctx, p[i], 0, "data");
+	return true;
+}
+
+static bool test_dup_talloc_s(struct torture_context *tctx)
+{
+	DATA_BLOB b = data_blob_string_const("abcd");
+	DATA_BLOB z = data_blob_dup_talloc_s(tctx, b);
+	int i;
+	uint8_t *p;
+
+	torture_assert_int_equal(tctx, z.length, 4, "length");
+	for (i = 0; i < b.length; i++)
+		torture_assert_int_equal(tctx, z.data[i], b.data[i], "data");
+	p = z.data; /* store pointer that will be freed */
+	data_blob_free(&z);
+	for (i = 0; i < b.length; i++)
+		/* coverity[use_after_free] */
+		torture_assert_int_equal(tctx, p[i], 0, "data");
+	return true;
+}
 
 static bool test_clear(struct torture_context *tctx)
 {
@@ -160,7 +212,10 @@ struct torture_suite *torture_local_util_data_blob(TALLOC_CTX *mem_ctx)
 
 	torture_suite_add_simple_test(suite, "string", test_string);
 	torture_suite_add_simple_test(suite, "string_null", test_string_null);
-	torture_suite_add_simple_test(suite, "zero", test_zero);;
+	torture_suite_add_simple_test(suite, "zero", test_zero);
+	torture_suite_add_simple_test(suite, "zero_s", test_zero_s);
+	torture_suite_add_simple_test(suite, "talloc_s", test_talloc_s);
+	torture_suite_add_simple_test(suite, "dup_s", test_dup_talloc_s);
 	torture_suite_add_simple_test(suite, "clear", test_clear);
 	torture_suite_add_simple_test(suite, "cmp", test_cmp);
 	torture_suite_add_simple_test(suite, "equal_const_time", test_equal_const_time);