From: Artur Wojcik Date: Thu, 10 Dec 2009 19:03:39 +0000 (-0700) Subject: Fix for NULL pointer dereference. X-Git-Tag: mdadm-3.1.2~63^2~13 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=791b666ae864cbd6f6c4513859afeb5fc624d02f;p=thirdparty%2Fmdadm.git Fix for NULL pointer dereference. Pointers '_dev' and '_disk' returned from call to function '_get_imsm_dev' and '_get_imsm_disk' may be NULL and will be dereferenced at lines 2933 and 2934, respectively. Signed-off-by: Artur Wojcik Signed-off-by: Dan Williams --- diff --git a/super-intel.c b/super-intel.c index 03dcbd5b..49e938dd 100644 --- a/super-intel.c +++ b/super-intel.c @@ -2938,6 +2938,10 @@ static int add_to_super_imsm_volume(struct supertype *st, mdu_disk_info_t *dk, struct imsm_dev *_dev = __get_imsm_dev(mpb, 0); struct imsm_disk *_disk = __get_imsm_disk(mpb, dl->index); + if (!_dev || !_disk) { + fprintf(stderr, Name ": BUG mpb setup error\n"); + return 1; + } *_dev = *dev; *_disk = dl->disk; sum = random32();